Bitcoin Core Fuzz Coverage Report

Coverage Report

Created: 2026-03-24 13:57

next uncovered line (L), next uncovered region (R), next uncovered branch (B)
/root/bitcoin/src/common/config.cpp
Line
Count
Source
1
// Copyright (c) 2023-present The Bitcoin Core developers
2
// Distributed under the MIT software license, see the accompanying
3
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5
#include <common/args.h>
6
7
#include <common/settings.h>
8
#include <logging.h>
9
#include <sync.h>
10
#include <tinyformat.h>
11
#include <univalue.h>
12
#include <util/chaintype.h>
13
#include <util/fs.h>
14
#include <util/string.h>
15
16
#include <algorithm>
17
#include <cassert>
18
#include <cstdlib>
19
#include <filesystem>
20
#include <fstream>
21
#include <iostream>
22
#include <sstream>
23
#include <list>
24
#include <map>
25
#include <memory>
26
#include <optional>
27
#include <string>
28
#include <string_view>
29
#include <utility>
30
#include <vector>
31
32
using util::TrimString;
33
using util::TrimStringView;
34
35
static bool GetConfigOptions(std::istream& stream, const std::string& filepath, std::string& error, std::vector<std::pair<std::string, std::string>>& options, std::list<SectionInfo>& sections)
36
0
{
37
0
    std::string str, prefix;
38
0
    std::string::size_type pos;
39
0
    int linenr = 1;
40
0
    while (std::getline(stream, str)) {
41
0
        bool used_hash = false;
42
0
        if ((pos = str.find('#')) != std::string::npos) {
43
0
            str = str.substr(0, pos);
44
0
            used_hash = true;
45
0
        }
46
0
        const static std::string pattern = " \t\r\n";
47
0
        str = TrimString(str, pattern);
48
0
        if (!str.empty()) {
49
0
            if (*str.begin() == '[' && *str.rbegin() == ']') {
50
0
                const std::string section = str.substr(1, str.size() - 2);
51
0
                sections.emplace_back(SectionInfo{section, filepath, linenr});
52
0
                prefix = section + '.';
53
0
            } else if (*str.begin() == '-') {
54
0
                error = strprintf("parse error on line %i: %s, options in configuration file must be specified without leading -", linenr, str);
Line
Count
Source
1172
0
#define strprintf tfm::format
55
0
                return false;
56
0
            } else if ((pos = str.find('=')) != std::string::npos) {
57
0
                std::string name = prefix + TrimString(std::string_view{str}.substr(0, pos), pattern);
58
0
                std::string_view value = TrimStringView(std::string_view{str}.substr(pos + 1), pattern);
59
0
                if (used_hash && name.find("rpcpassword") != std::string::npos) {
60
0
                    error = strprintf("parse error on line %i, using # in rpcpassword can be ambiguous and should be avoided", linenr);
Line
Count
Source
1172
0
#define strprintf tfm::format
61
0
                    return false;
62
0
                }
63
0
                options.emplace_back(name, value);
64
0
                if ((pos = name.rfind('.')) != std::string::npos && prefix.length() <= pos) {
65
0
                    sections.emplace_back(SectionInfo{name.substr(0, pos), filepath, linenr});
66
0
                }
67
0
            } else {
68
0
                error = strprintf("parse error on line %i: %s", linenr, str);
Line
Count
Source
1172
0
#define strprintf tfm::format
69
0
                if (str.size() >= 2 && str.starts_with("no")) {
70
0
                    error += strprintf(", if you intended to specify a negated option, use %s=1 instead", str);
Line
Count
Source
1172
0
#define strprintf tfm::format
71
0
                }
72
0
                return false;
73
0
            }
74
0
        }
75
0
        ++linenr;
76
0
    }
77
0
    return true;
78
0
}
79
80
0
bool IsConfSupported(KeyInfo& key, std::string& error) {
81
0
    if (key.name == "conf") {
82
0
        error = "conf cannot be set in the configuration file; use includeconf= if you want to include additional config files";
83
0
        return false;
84
0
    }
85
0
    if (key.name == "reindex") {
86
        // reindex can be set in a config file but it is strongly discouraged as this will cause the node to reindex on
87
        // every restart. Allow the config but throw a warning
88
0
        LogWarning("reindex=1 is set in the configuration file, which will significantly slow down startup. Consider removing or commenting out this option for better performance, unless there is currently a condition which makes rebuilding the indexes necessary");
Line
Count
Source
96
0
#define LogWarning(...) LogPrintLevel_(BCLog::LogFlags::ALL, BCLog::Level::Warning, /*should_ratelimit=*/true, __VA_ARGS__)
Line
Count
Source
89
0
#define LogPrintLevel_(category, level, should_ratelimit, ...) LogPrintFormatInternal(SourceLocation{__func__}, category, level, should_ratelimit, __VA_ARGS__)
89
0
        return true;
90
0
    }
91
0
    return true;
92
0
}
93
94
bool ArgsManager::ReadConfigStream(std::istream& stream, const std::string& filepath, std::string& error, bool ignore_invalid_keys)
95
0
{
96
0
    LOCK(cs_args);
Line
Count
Source
266
0
#define LOCK(cs) UniqueLock UNIQUE_NAME(criticalblock)(MaybeCheckNotHeld(cs), #cs, __FILE__, __LINE__)
Line
Count
Source
11
0
#define UNIQUE_NAME(name) PASTE2(name, __COUNTER__)
Line
Count
Source
9
0
#define PASTE2(x, y) PASTE(x, y)
Line
Count
Source
8
0
#define PASTE(x, y) x ## y
97
0
    std::vector<std::pair<std::string, std::string>> options;
98
0
    if (!GetConfigOptions(stream, filepath, error, options, m_config_sections)) {
99
0
        return false;
100
0
    }
101
0
    for (const std::pair<std::string, std::string>& option : options) {
102
0
        KeyInfo key = InterpretKey(option.first);
103
0
        std::optional<unsigned int> flags = GetArgFlags_('-' + key.name);
104
0
        if (!IsConfSupported(key, error)) return false;
105
0
        if (flags) {
106
0
            std::optional<common::SettingsValue> value = InterpretValue(key, &option.second, *flags, error);
107
0
            if (!value) {
108
0
                return false;
109
0
            }
110
0
            m_settings.ro_config[key.section][key.name].push_back(*value);
111
0
        } else {
112
0
            if (ignore_invalid_keys) {
113
0
                LogWarning("Ignoring unknown configuration value %s", option.first);
Line
Count
Source
96
0
#define LogWarning(...) LogPrintLevel_(BCLog::LogFlags::ALL, BCLog::Level::Warning, /*should_ratelimit=*/true, __VA_ARGS__)
Line
Count
Source
89
0
#define LogPrintLevel_(category, level, should_ratelimit, ...) LogPrintFormatInternal(SourceLocation{__func__}, category, level, should_ratelimit, __VA_ARGS__)
114
0
            } else {
115
0
                error = strprintf("Invalid configuration value %s", option.first);
Line
Count
Source
1172
0
#define strprintf tfm::format
116
0
                return false;
117
0
            }
118
0
        }
119
0
    }
120
0
    return true;
121
0
}
122
123
bool ArgsManager::ReadConfigString(const std::string& str_config)
124
0
{
125
0
    std::istringstream streamConfig(str_config);
126
0
    {
127
0
        LOCK(cs_args);
Line
Count
Source
266
0
#define LOCK(cs) UniqueLock UNIQUE_NAME(criticalblock)(MaybeCheckNotHeld(cs), #cs, __FILE__, __LINE__)
Line
Count
Source
11
0
#define UNIQUE_NAME(name) PASTE2(name, __COUNTER__)
Line
Count
Source
9
0
#define PASTE2(x, y) PASTE(x, y)
Line
Count
Source
8
0
#define PASTE(x, y) x ## y
128
0
        m_settings.ro_config.clear();
129
0
        m_config_sections.clear();
130
0
    }
131
0
    std::string error;
132
0
    return ReadConfigStream(streamConfig, "", error);
133
0
}
134
135
bool ArgsManager::ReadConfigFiles(std::string& error, bool ignore_invalid_keys)
136
0
{
137
0
    {
138
0
        LOCK(cs_args);
Line
Count
Source
266
0
#define LOCK(cs) UniqueLock UNIQUE_NAME(criticalblock)(MaybeCheckNotHeld(cs), #cs, __FILE__, __LINE__)
Line
Count
Source
11
0
#define UNIQUE_NAME(name) PASTE2(name, __COUNTER__)
Line
Count
Source
9
0
#define PASTE2(x, y) PASTE(x, y)
Line
Count
Source
8
0
#define PASTE(x, y) x ## y
139
0
        m_settings.ro_config.clear();
140
0
        m_config_sections.clear();
141
0
        const auto conf_val = GetPathArg_("-conf", BITCOIN_CONF_FILENAME);
142
0
        m_config_path = (conf_val.is_absolute() || conf_val.empty()) ? conf_val : fsbridge::AbsPathJoin(GetDataDir(/*net_specific=*/false), conf_val);
143
0
    }
144
145
0
    const auto conf_path{GetConfigFilePath()};
146
0
    std::ifstream stream;
147
0
    if (!conf_path.empty()) { // path is empty when -noconf is specified
148
0
        if (fs::is_directory(conf_path)) {
149
0
            error = strprintf("Config file \"%s\" is a directory.", fs::PathToString(conf_path));
Line
Count
Source
1172
0
#define strprintf tfm::format
150
0
            return false;
151
0
        }
152
0
        stream = std::ifstream{conf_path.std_path()};
153
        // If the file is explicitly specified, it must be readable
154
0
        if (IsArgSet("-conf") && !stream.good()) {
155
0
            error = strprintf("specified config file \"%s\" could not be opened.", fs::PathToString(conf_path));
Line
Count
Source
1172
0
#define strprintf tfm::format
156
0
            return false;
157
0
        }
158
0
    }
159
    // ok to not have a config file
160
0
    if (stream.good()) {
161
0
        if (!ReadConfigStream(stream, fs::PathToString(conf_path), error, ignore_invalid_keys)) {
162
0
            return false;
163
0
        }
164
        // `-includeconf` cannot be included in the command line arguments except
165
        // as `-noincludeconf` (which indicates that no included conf file should be used).
166
0
        bool use_conf_file{true};
167
0
        {
168
0
            LOCK(cs_args);
Line
Count
Source
266
0
#define LOCK(cs) UniqueLock UNIQUE_NAME(criticalblock)(MaybeCheckNotHeld(cs), #cs, __FILE__, __LINE__)
Line
Count
Source
11
0
#define UNIQUE_NAME(name) PASTE2(name, __COUNTER__)
Line
Count
Source
9
0
#define PASTE2(x, y) PASTE(x, y)
Line
Count
Source
8
0
#define PASTE(x, y) x ## y
169
0
            if (auto* includes = common::FindKey(m_settings.command_line_options, "includeconf")) {
170
                // ParseParameters() fails if a non-negated -includeconf is passed on the command-line
171
0
                assert(common::SettingsSpan(*includes).last_negated());
172
0
                use_conf_file = false;
173
0
            }
174
0
        }
175
0
        if (use_conf_file) {
176
0
            std::string chain_id = GetChainTypeString();
177
0
            std::vector<std::string> conf_file_names;
178
179
0
            auto add_includes = [&](const std::string& network, size_t skip = 0) {
180
0
                size_t num_values = 0;
181
0
                LOCK(cs_args);
Line
Count
Source
266
0
#define LOCK(cs) UniqueLock UNIQUE_NAME(criticalblock)(MaybeCheckNotHeld(cs), #cs, __FILE__, __LINE__)
Line
Count
Source
11
0
#define UNIQUE_NAME(name) PASTE2(name, __COUNTER__)
Line
Count
Source
9
0
#define PASTE2(x, y) PASTE(x, y)
Line
Count
Source
8
0
#define PASTE(x, y) x ## y
182
0
                if (auto* section = common::FindKey(m_settings.ro_config, network)) {
183
0
                    if (auto* values = common::FindKey(*section, "includeconf")) {
184
0
                        for (size_t i = std::max(skip, common::SettingsSpan(*values).negated()); i < values->size(); ++i) {
185
0
                            conf_file_names.push_back((*values)[i].get_str());
186
0
                        }
187
0
                        num_values = values->size();
188
0
                    }
189
0
                }
190
0
                return num_values;
191
0
            };
192
193
            // We haven't set m_network yet (that happens in SelectParams()), so manually check
194
            // for network.includeconf args.
195
0
            const size_t chain_includes = add_includes(chain_id);
196
0
            const size_t default_includes = add_includes({});
197
198
0
            for (const std::string& conf_file_name : conf_file_names) {
199
0
                const auto include_conf_path{AbsPathForConfigVal(*this, fs::PathFromString(conf_file_name), /*net_specific=*/false)};
200
0
                if (fs::is_directory(include_conf_path)) {
201
0
                    error = strprintf("Included config file \"%s\" is a directory.", fs::PathToString(include_conf_path));
Line
Count
Source
1172
0
#define strprintf tfm::format
202
0
                    return false;
203
0
                }
204
0
                std::ifstream conf_file_stream{include_conf_path.std_path()};
205
0
                if (conf_file_stream.good()) {
206
0
                    if (!ReadConfigStream(conf_file_stream, conf_file_name, error, ignore_invalid_keys)) {
207
0
                        return false;
208
0
                    }
209
0
                    LogInfo("Included configuration file %s\n", conf_file_name);
Line
Count
Source
95
0
#define LogInfo(...) LogPrintLevel_(BCLog::LogFlags::ALL, BCLog::Level::Info, /*should_ratelimit=*/true, __VA_ARGS__)
Line
Count
Source
89
0
#define LogPrintLevel_(category, level, should_ratelimit, ...) LogPrintFormatInternal(SourceLocation{__func__}, category, level, should_ratelimit, __VA_ARGS__)
210
0
                } else {
211
0
                    error = "Failed to include configuration file " + conf_file_name;
212
0
                    return false;
213
0
                }
214
0
            }
215
216
            // Warn about recursive -includeconf
217
0
            conf_file_names.clear();
218
0
            add_includes(chain_id, /* skip= */ chain_includes);
219
0
            add_includes({}, /* skip= */ default_includes);
220
0
            std::string chain_id_final = GetChainTypeString();
221
0
            if (chain_id_final != chain_id) {
222
                // Also warn about recursive includeconf for the chain that was specified in one of the includeconfs
223
0
                add_includes(chain_id_final);
224
0
            }
225
0
            for (const std::string& conf_file_name : conf_file_names) {
226
0
                tfm::format(std::cerr, "warning: -includeconf cannot be used from included files; ignoring -includeconf=%s\n", conf_file_name);
227
0
            }
228
0
        }
229
0
    }
230
231
    // If datadir is changed in .conf file:
232
0
    ClearPathCache();
233
0
    if (!CheckDataDirOption(*this)) {
234
0
        error = strprintf("specified data directory \"%s\" does not exist.", GetArg("-datadir", ""));
Line
Count
Source
1172
0
#define strprintf tfm::format
235
0
        return false;
236
0
    }
237
0
    return true;
238
0
}
239
240
fs::path AbsPathForConfigVal(const ArgsManager& args, const fs::path& path, bool net_specific)
241
0
{
242
0
    if (path.is_absolute() || path.empty()) {
243
0
        return path;
244
0
    }
245
0
    return fsbridge::AbsPathJoin(net_specific ? args.GetDataDirNet() : args.GetDataDirBase(), path);
246
0
}